Add Python 3.12 to test matrix #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ogenstad I would probably try rolling nornir-napalm to 0.5.0 (since your error seems related to outdated ncclient which is possibly being caused by older nornir-napalm): https://github.com/nornir-automation/nornir/blob/main/pyproject.toml#L46 And it should be updated anyways. |
|
@ktbyers, thanks. Looks like it got a bit further but hit the next problem. Might be that we just need to upgrade nbval, I'll try to return to it a bit later. |
ogenstad
force-pushed
the
ogenstad/python312-tests
branch
from
f6ea678
to
c1d147c
Compare
Pull Request Test Coverage Report for Build 9890392497Details
💛 - Coveralls |
ktbyers
approved these changes
Jul 11, 2024
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.